[4474] Add EMF Services for Query View #4475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
AxelRICHARD
force-pushed
the
ari/enh/emfServicesQueryView
branch
from
84f22bd to
1ff0ac0
Compare
Bug: #4474 Signed-off-by: Axel RICHARD <[email protected]>
sbegaudeau
force-pushed
the
ari/enh/emfServicesQueryView
branch
from
1ff0ac0 to
30c35b7
Compare
sbegaudeau
reviewed
Jan 28, 2025
| @@ -27,6 +28,6 @@ | |||
| public class PapayaInterpreterJavaServiceProvider implements IInterpreterJavaServiceProvider { | |||
| @Override | |||
| public List<Class<?>> getServiceClasses(IEditingContext editingContext) { | |||
| return List.of(PapayaQueryServices.class); | |||
| return List.of(PapayaQueryServices.class, EMFQueryServices.class); | |||
There was a problem hiding this comment.
You have already added this in another service provider, no need to do it twice :)
|
|
||
| public void eSet(EObject object, String eStructuralFeatureName, Object newValue) { | ||
| var eStructuralFeature = object.eClass().getEStructuralFeature(eStructuralFeatureName); | ||
| object.eSet(eStructuralFeature, newValue); |
There was a problem hiding this comment.
I'll just add a check to ensure that the feature is not null
| } | ||
|
|
||
| public void eUnset(EObject object, String eStructuralFeatureName) { | ||
| var eStructuralFeature = object.eClass().getEStructuralFeature(eStructuralFeatureName); |
sbegaudeau
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: #4474
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,difficulty:,type:)CHANGELOG.adocbeen updated to reference the relevant issues?CHANGELOG.adoc? (Including changes in the GraphQL API)CHANGELOG.adoc? For example indoc/screenshots/2022.5.0-my-new-feature.pngArchitectural decision records (ADR)
[doc]?CHANGELOG.adoc?Dependencies
CHANGELOG.adoc?CHANGELOG.adoc?Frontend
This section is not relevant if your contribution does not come with changes to the frontend.
General purpose
Typing
We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).
useMutation<DATA_TYPE, VARIABLE_TYPE>(…)useQuery<DATA_TYPE, VARIABLE_TYPE>(…)useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)useState<STATE_TYPE>(…)?.(if the GraphQL API specifies that a field cannot benull, do not treat it has potentiallynullfor example)let diagram: Diagram | null = null;)Backend
This section is not relevant if your contribution does not come with changes to the backend.
General purpose
Architecture
Review
How to test this PR?
Please describe here the various use cases to test this pull request