Lsp edit #1
Merged
Lsp edit #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoenemann
reviewed
Nov 2, 2018
| } | ||
|
|
||
| undo(context: CommandExecutionContext): CommandResult { | ||
| // TODO implement revert workspace edit |
There was a problem hiding this comment.
Please create an issue for this.
| @@ -0,0 +1,122 @@ | |||
| /******************************************************************************** | |||
| * Copyright (c) 2017-2018 TypeFox and others. | |||
src/sprotty/languageserver/delete.ts
Outdated
| @@ -0,0 +1,89 @@ | |||
| /******************************************************************************** | |||
| * Copyright (c) 2017-2018 TypeFox and others. | |||
src/sprotty/languageserver/index.ts
Outdated
| @@ -0,0 +1,21 @@ | |||
| /******************************************************************************** | |||
| * Copyright (c) 2017-2018 TypeFox and others. | |||
src/sprotty/languageserver/ranged.ts
Outdated
| @@ -0,0 +1,40 @@ | |||
| /******************************************************************************** | |||
| * Copyright (c) 2017-2018 TypeFox and others. | |||
src/theia/languageserver/index.ts
Outdated
| @@ -0,0 +1,17 @@ | |||
| /******************************************************************************** | |||
| * Copyright (c) 2017-2018 TypeFox and others. | |||
| @@ -0,0 +1,69 @@ | |||
| /******************************************************************************** | |||
| * Copyright (c) 2017-2018 TypeFox and others. | |||
| @@ -0,0 +1,28 @@ | |||
| /******************************************************************************** | |||
| * Copyright (c) 2017-2018 TypeFox and others. | |||
| * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0 | ||
| ********************************************************************************/ | ||
|
|
||
| export * from './languageserver-diagram-contributions' |
There was a problem hiding this comment.
What about languageserver-diagram-module?
| handleExportSvgAction(action: ExportSvgAction): boolean { | ||
| this.connector.then(c => c.save(this.sourceUri, action)) | ||
| return true | ||
| } | ||
|
|
||
| handleRequestPopupModel(action: RequestPopupModelAction): boolean { | ||
| if (action.elementId === this.currentRoot.id) { |
There was a problem hiding this comment.
We should generalize this so we allow multiple popup models and merge those received from the server with the locally created ones. Then we can also support palettes on elements other than the root, e.g. large container nodes. This should be handled in a separate issue / PR.
There was a problem hiding this comment.
spoenemann
reviewed
Nov 2, 2018
| readonly kind = DeleteWithWorkspaceEditCommand.KIND | ||
|
|
||
| // TODO: consider URIs from individual element traces | ||
| constructor(readonly workspace: Workspace, readonly sourceUri: string) {} |
There was a problem hiding this comment.
This is not a serializable action, right? Do we need to make a distinction between serializable and non-serializable actions?
Signed-off-by: Jan Koehnlein <[email protected]>
spoenemann
reviewed
Nov 2, 2018
| @@ -59,6 +74,18 @@ export class TheiaDiagramServer extends DiagramServer { | |||
| this.resolveConnector = resolve) | |||
| } | |||
|
|
|||
| getConnector() { | |||
There was a problem hiding this comment.
Just curious, why did you choose Java-style getters here instead of TypeScript getters?
There was a problem hiding this comment.
Because it's a promise.
spoenemann
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.