Update with spoenemann comments

Signed-off-by: Guillaume Fontorbe <[email protected]>
eclipse-sprotty · Feb 12, 2024 · ad34d59 · ad34d59
1 parent d549fa2
commit ad34d59
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/packages/sprotty-protocol/src/model.ts b/packages/sprotty-protocol/src/model.ts
@@ -166,7 +166,8 @@ export interface ModelLayoutOptions {
     minWidth?: number
     minHeight?: number
     resizeContainer?: boolean
-    [key: string]: string | number | boolean | undefined};
+    [key: string]: string | number | boolean | undefined
+};
 
 export type HAlignment = 'left' | 'center' | 'right';
 export type VAlignment = 'top' | 'center' | 'bottom';
@@ -175,13 +176,13 @@ export type VAlignment = 'top' | 'center' | 'bottom';
  * Used to identify model elements that specify a layout to apply to their children.
  */
 export interface LayoutContainer extends LayoutableChild {
-    layout: Layout
+    layout: LayoutKind
 }
 
 /**
  * Type for the layout property of a `LayoutContainer`.
  */
-export type Layout = 'stack' | 'vbox' | 'hbox' | (string & {});
+export type LayoutKind = 'stack' | 'vbox' | 'hbox' | (string & {});
 
 /**
  * Feature extension interface for `alignFeature`.

diff --git a/packages/sprotty/src/features/bounds/layout-options.ts b/packages/sprotty/src/features/bounds/layout-options.ts
@@ -16,6 +16,12 @@
 
 import { JsonMap } from 'sprotty-protocol/lib/utils/json';
 
+/** @deprecated Use HAlignment from `sprotty-protocol` instead */
+export type HAlignment = 'left' | 'center' | 'right';
+
+/** @deprecated Use VAlignment from `sprotty-protocol` instead */
+export type VAlignment = 'top' | 'center' | 'bottom';
+
 export interface AbstractLayoutOptions extends JsonMap {
     resizeContainer: boolean
     paddingTop: number