svg export via cli command and headless browser #439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
spoenemann
reviewed
Feb 26, 2024
| "file-saver": "^2.0.5", | ||
| "inversify": "~6.0.2", | ||
| "puppeteer": "^22.2.0", |
There was a problem hiding this comment.
We should not have these dependencies in the base package of Sprotty. If we go for this solution, the new code should be moved to a new package.
|
This is now solved with #454. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first try regarding #421.
Solution for now: listening to an custom browser event in the respective app (here it is the JSXample page) which will be fired by an cli command (
sprotty export http://localhost:8080/jsxample/jsxample.html) .Very pragmatic. Maybe there is a more general/elegant way that is to be discussed.
Hence the Draft PR.