Move also edge bendpoints of nested nodes when parent is moved #442
Conversation
…so taken into account Fixes Moving multiple containers does not show feedback move of internal edge bendpoints #428 Signed-off-by: Jan Bicker <[email protected]>
| } | ||
| }); | ||
| }; | ||
| const handleEdgesForChildren = (el: SModelElementImpl) => { |
There was a problem hiding this comment.
Do we really need to move all edges for children? If an edge is contained in the element, its coordinates are usually relative to that element, so we don't need to change them when the element is moved.
There was a problem hiding this comment.
Yes. They need to be put into attachedEdgeShifts because otherwise they aren't handled here and the routing points stay where they are.
There was a problem hiding this comment.
But what happens if package A contains nodes B and C, and those two nodes are connected by an edge which is also a child of A? Could you try that case? What we need to avoid is moving routing points for elements that are relative to a moved container.
There was a problem hiding this comment.
I tried that case. I changed the class diagram because of that case. Before the routing points of such an edge didn't move at all with the parent but stay at their absolute position.
Fixes #428
The classdiagram example has been changed as well in order to demonstrate this case better.