Skip to content

Commit

Permalink
Update license check and pre-commit
Browse files Browse the repository at this point in the history
Previously both gave warnings.
Pre-commit as using Node.js 16
License check as error code was presented
  • Loading branch information
erikbosch committed Jun 14, 2024
1 parent af127a9 commit e5814ad
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 6 deletions.
10 changes: 8 additions & 2 deletions src/common/workflows/check-licenses.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ on:
pull_request:
branches:
- main
push:
branches:
- main

jobs:
check-licenses:
Expand Down Expand Up @@ -58,10 +61,12 @@ jobs:

- name: Run dash
shell: bash
continue-on-error: true
run: |
wget -O dash.jar "https://repo.eclipse.org/content/repositories/dash-licenses/org/eclipse/dash/org.eclipse.dash.licenses/1.0.2/org.eclipse.dash.licenses-1.0.2.jar"
java -jar dash.jar clearlydefined.input -summary DEPENDENCIES
java -jar dash.jar clearlydefined.input -summary DEPENDENCIES > dash.out 2>&1 || true
echo -e "Dash output: \n\`\`\` " >> $GITHUB_STEP_SUMMARY
cat dash.out >> $GITHUB_STEP_SUMMARY
echo -e "\n\`\`\`"
- name: Upload dash input/output as artifacts
uses: actions/upload-artifact@v4
Expand All @@ -71,3 +76,4 @@ jobs:
path: |
clearlydefined.input
DEPENDENCIES
dash.out
2 changes: 1 addition & 1 deletion src/cpp-app/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,4 +93,4 @@ jobs:
cat code-coverage-results.md >> $GITHUB_STEP_SUMMARY
- name: Run Linters
uses: pre-commit/[email protected].0
uses: pre-commit/[email protected].1
2 changes: 1 addition & 1 deletion src/cpp-sdk/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,4 +107,4 @@ jobs:
# path: code-coverage-results.md

- name: Run Linters
uses: pre-commit/[email protected].0
uses: pre-commit/[email protected].1
2 changes: 1 addition & 1 deletion src/python-app/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
git config --global --add safe.directory $( pwd )
- name: Run Linters
uses: pre-commit/[email protected].0
uses: pre-commit/[email protected].1

- name: Clone Release Documentation Action repository
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion src/python-sdk/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
python3 -m pip install tox-gh-actions
- name: Run Linters
uses: pre-commit/[email protected].0
uses: pre-commit/[email protected].1

- name: Run the databroker binary
run: |
Expand Down

0 comments on commit e5814ad

Please sign in to comment.