Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertx Builder API + remove cluster manager from VertxOptions #4959

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

vietj
Copy link
Member

@vietj vietj commented Nov 19, 2023

  • Vertx has an internal builder API that is used by the launcher
  • VertxOptions exposes services like the cluster manager, the metrics instance, the tracer instance which are not suited for options, since options should focus on configuration data

This PR provides a VertxBuilder API that can be used to override the the vertx services exposed in VertxOptions, VertxOptions related services have been removed.

// Before
Future<Vertx> fut = Vertx.clusteredVertx(new VertxOptions().setClusterManager(clusterManager));

// After
Future<Vertx> fut = Vertx.builder().withClusterManager(clusterManager).buildClustered();

This should be back-ported to 4.x branches.

@vietj vietj added this to the 5.0.0 milestone Nov 19, 2023
@vietj vietj force-pushed the vertx-builder-api branch 5 times, most recently from 015101a to 02710be Compare November 20, 2023 12:06
@vietj vietj force-pushed the vertx-builder-api branch from 02710be to f1a29a1 Compare November 20, 2023 13:13
@vietj vietj merged commit 4ff14fa into master Nov 20, 2023
@vietj vietj deleted the vertx-builder-api branch November 20, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant