RecordParser may grow the initial buffer until the first event is emitted #4960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tted See eclipse-vertx#4811 This can be a problem if the received Buffer is backed by a Netty ByteBuff with low capacity. Also, we shouldn't assume we can modify input. To reproduce the issue, the client and the server should communicate over an encrypted connection. In this case, VertxHandler#safeHandler does not copy the received buffer because it's not pooled. These buffers are created at the encryption support layer and have a limited, low capacity. The tests in this commit don't pass without the fix in RecordParser (copy initial buffer). Signed-off-by: Thomas Segismont <[email protected]>
tsegismont
force-pushed
the
issues/4811
branch
from
7fd8275 to
4d52f62
Compare
|
The test failures are due to: 🤦♂️ |
Instead of a self-signed certificate created at runtime. Signed-off-by: Thomas Segismont <[email protected]>
|
As agreed off-list, will merge this with an extra commit adding a comment in the |
Signed-off-by: Thomas Segismont <[email protected]>
tsegismont
added a commit
that referenced
this pull request
Nov 22, 2023
…tted (#4960) * RecordParser may grow the initial buffer until the first event is emitted See #4811 This can be a problem if the received Buffer is backed by a Netty ByteBuff with low capacity. Also, we shouldn't assume we can modify input. To reproduce the issue, the client and the server should communicate over an encrypted connection. In this case, VertxHandler#safeHandler does not copy the received buffer because it's not pooled. These buffers are created at the encryption support layer and have a limited, low capacity. The tests in this commit don't pass without the fix in RecordParser (copy initial buffer). Signed-off-by: Thomas Segismont <[email protected]> * ClientResponseParserTest: use SERVER_PEM Instead of a self-signed certificate created at runtime. Signed-off-by: Thomas Segismont <[email protected]> * Add comment in RecordParserImpl Signed-off-by: Thomas Segismont <[email protected]> --------- Signed-off-by: Thomas Segismont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4811
This can be a problem if the received Buffer is backed by a Netty
ByteBuffwith low capacity.Also, we shouldn't assume we can modify input.