Fixes updates to traffic shaping options with shared servers #5282
+120
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the update-path for traffic shaping options to check for the existence of the traffic shaping handler only for the actual server.
sarankk
reviewed
Aug 14, 2024
…hey do not change This is especially relevant for shared servers, where we now 1) update the actual-server's options, and 2) only perform the update when the traffic options change.
vietj
reviewed
Jan 9, 2025
src/test/java/io/vertx/core/http/HttpBandwidthLimitingTest.java
Outdated
Show resolved
Hide resolved
vietj
reviewed
Jan 9, 2025
src/test/java/io/vertx/core/http/HttpBandwidthLimitingTest.java
Outdated
Show resolved
Hide resolved
vietj
reviewed
Jan 9, 2025
src/test/java/io/vertx/core/http/HttpBandwidthLimitingTest.java
Outdated
Show resolved
Hide resolved
vietj
reviewed
Jan 10, 2025
| for (int i = 0; i < numEventLoops; i++) { | ||
| servers.forEach(s -> s.updateTrafficShapingOptions(updatedTrafficOptions)); | ||
| } | ||
| startPromise.complete(); |
There was a problem hiding this comment.
we need to complete the start promise with the result of updateTrafficShapingOptions to ensure proper sequentiality in the test and avoid races, e.g. using a CompositeFuture.all(...) with the future returned by the updates seems the easiest way
There was a problem hiding this comment.
yep, good point. updateTrafficShapingOptions is synchronous currently, but added steps to track those actions via promises that chains with the start promise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This fixes the update-path for traffic shaping options to check for the existence of the traffic shaping handler only for the actual server. Currently, updating traffic-shaping options in a shared-server setting results in
IllegalStateException, as the traffic-shaping handler is not set for the worker (non-main) servers.Conformance:
You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines