Skip to content

Commit

Permalink
fixup! tooling: Make cloe a super-build of all packages
Browse files Browse the repository at this point in the history
  • Loading branch information
cassava committed May 14, 2024
1 parent 9422859 commit fd482dc
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/build-cloe.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,10 @@ jobs:
# 2. Build cloe super-package in editable mode and run tests
- "export-vendor editable all smoketest TEST_CONANFILES=tests/conanfile_all.py"

# 3. Build individual packages in editable mode and run tests
# TODO: Enable this again when Conan 2 is used.
# 3. TODO: Build individual packages in editable mode and run tests
# This cannot be currently enabled because of a Conan deficiency in v1.
# Once all build tooling is based on Conan v2, we can re-enable this use-case.
# Until then, use the previous target for this use-case.
#- "export-vendor editable-select build-all smoketest TEST_CONANFILES=tests/conanfile_split.py"
env:
CONAN_NON_INTERACTIVE: "yes"
Expand Down
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,9 @@ See the [upstream issue](https://github.com/conan-io/conan/issues/10544).
In Conan 1, a dependency in a lockfile is only in host or build context, not
both. Unfortunately, this is only fixed in Conan 2.
The use-case for build-all is to build everything in editable mode.
For that, use the new super-build instead of building individual packages.
[1]: https://conan.io
[2]: https://docs.microsoft.com/en-us/windows/wsl/about
[3]: https://ubuntu.com
Expand Down
6 changes: 6 additions & 0 deletions vendor/esmini-data/conanfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@ class ESMiniData(ConanFile):
description = "Basic OpenScenario player example data"
topics = ("Environment Simulator", "OpenScenario", "OpenDrive")

# This package may not be built while all other packages are built
# because it is solely a runtime dependency. Because it only copies
# a few files, the only thing that may take a longer period of time
# is downloading the esmini archive. For now, this is acceptable.
build_policy = "missing"

def export_sources(self):
files.export_conandata_patches(self)

Expand Down

0 comments on commit fd482dc

Please sign in to comment.