Release/0.21.0 #205
Merged
Release/0.21.0 #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cassava
force-pushed
the
release/0.21.0
branch
from
65a9726 to
ac7b4de
Compare
clonker
reviewed
Jan 31, 2024
cassava
commented
Feb 1, 2024
cassava
commented
Feb 1, 2024
cassava
commented
Feb 1, 2024
cassava
commented
Feb 1, 2024
cassava
commented
Feb 1, 2024
The packages are now fully forward compatible with those from the
Conan Center Index. This means we can swap with other versions
of open-simulation-interface from the CCI without any other changes.
BREAKING CHANGES:
- Conan recipe requires Conan >= 1.60
- When including library in CMakeLists.txt, you now need to use:
find_package(open_simulation_interface REQUIRED)
- When referring to target in CMakeLists.txt, you need to refer to:
open_simulation_interface::open_simulation_interface
- When including headers, the osi headers are now in the osi3 folder:
#include <osi3/osi_ground_truth.pb.h>
cassava
force-pushed
the
release/0.21.0
branch
from
351f8ac to
8ce98e8
Compare
|
Had to rebase to include the latest changes from master. |
clonker
suggested changes
Feb 2, 2024
cassava
force-pushed
the
release/0.21.0
branch
from
8ce98e8 to
c1433c5
Compare
clonker
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 0.21.0 PR.
I recommend reviewing the PR commit-by-commit. Especially because some of the "Migrate package to Conan 2.0 compatibility" commits can be a bit much; seeing all the changes at once is overwhelming.
Once you realize the changes are quite simple, but just need to be applied everywhere, the reviewing should be easier.