Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.23.0 #231

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Release 0.23.0 #231

merged 4 commits into from
Apr 26, 2024

Conversation

cassava
Copy link
Contributor

@cassava cassava commented Apr 23, 2024

No description provided.

@cassava cassava added this to the 0.23.0 milestone Apr 23, 2024
@cassava cassava self-assigned this Apr 23, 2024
@cassava cassava force-pushed the release/0.23.0 branch 2 times, most recently from bbafa2a to a24aa01 Compare April 23, 2024 10:26
Copy link

@clonker clonker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cassava added 2 commits April 26, 2024 10:08
For some reason, the exact same build approach on a clean machine gives
the following results:

- local build: ok
- docker dev container build: ok
- docker build image build: fail

When linking the executable test-osi, the following error occurred:

    /usr/bin/ld: libcloe-osi.so.0.22.0-nightly: undefined reference to
        `void
        cloe::utility::osi_to_json<osi3::SensorData>(
            osi3::SensorData const&,
            std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >*
        )'

This commit fixes that by explicitely instantiating this template
variant.
@cassava cassava merged commit 27dbc38 into master Apr 26, 2024
11 checks passed
@cassava cassava deleted the release/0.23.0 branch July 11, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants