Add json schema dialect property #675
Merged
+38
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to implement this in SmallRye before merging to validate that the new tests are passable. |
|
Removed the annotation field. Any non-default schema dialect would need explicit support from the implementation and even if we did have an implementation which supported a non-default schema dialect, I'm not sure this is the most intuitive way of specifying that it should be used. |
Azquelt
force-pushed
the
add-json-schema-dialect
branch
from
18b6ad4 to
f245695
Compare
|
SmallRye passes the TCK with smallrye/smallrye-open-api#2163 |
MikeEdgar
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
jsonSchemaDialectto the modeland annotations.In the model test, I've put the JSON Schema 2020-12 dialect and as it's in the model, I expect it to be passed through as-is.
In the annotation test, I've put the OAS default schema dialect since I don't think we can reasonably rely on an implementation to have well defined behaviour for any other values. An implementation could reasonably do any of the following:generate schemas in the specified dialectgenerate schemas in the OAS default dialect and set$schemain all of them, overriding the default set at the top levelreport an error and generate nothingFixes #660