Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure to include metrics and merge specs together - prototype 1 #138

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

Emily-Jiang
Copy link
Member

@Emily-Jiang Emily-Jiang commented Nov 7, 2023

This PR demonstrates the following structure:
spec
tck

  • tracing
  • metrics

The advantages:

  • fully embrace the common parts and separate for spec point of view
  • clear separation of spec and tck
  • TCK shares the same build infrastructure

Disadvantage:

  • The existing tracing tck jar has to use a different group id.

@Emily-Jiang Emily-Jiang changed the title Restructure to include metrics and merge specs together Restructure to include metrics and merge specs together - prototype Nov 7, 2023
@Emily-Jiang Emily-Jiang changed the title Restructure to include metrics and merge specs together - prototype Restructure to include metrics and merge specs together - prototype 1 Nov 13, 2023
@Azquelt
Copy link
Member

Azquelt commented Nov 27, 2023

The current project layout looks like this: (formatted as folder-name:maven-coordinates)

  • root: org.eclipse.microprofile.telemetry:microprofile-telemetry-parent
    • tracing: org.eclipse.microprofile.telemetry.tracing:microprofile-telemetry-tracing-parent
      • spec: org.eclipse.microprofile.telemetry.tracing:microprofile-telemetry-tracing-spec
      • tck: org.eclipse.microprofile.telemetry.tracing:microprofile-telemetry-tracing-tck

With this proposal, the project layout would look like this:

  • root: org.eclipse.microprofile.telemetry:microprofile-telemetry-parent
    • spec: org.eclipse.microprofile.telemetry:microprofile-telemetry-spec
    • tck: org.eclipse.microprofile.telemetry:microprofile-telemetry-tck-parent
      • metrics: org.eclipse.microprofile.telemetry:microprofile-telemetry-metrics-tck
      • tracing: org.eclipse.microprofile.telemetry:microprofile-telemetry-tracing-tck

Note that now all the artifacts are under the org.eclipse.microprofile.telemetry groupID.

The spec source files are arranged like this:

  • spec
    • src/main/asciidoc
      • microprofile-telemetry-spec.asciidoc
      • metrics.adoc
      • tracing.adoc

@Emily-Jiang Emily-Jiang requested a review from pdudits December 4, 2023 17:02
tck/metrics/pom.xml Outdated Show resolved Hide resolved
tck/tracing/README.adoc Outdated Show resolved Hide resolved
Copy link
Member

@Azquelt Azquelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Emily-Jiang Emily-Jiang merged commit b55bcd0 into eclipse:main Dec 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants