Specification of Telemetry Metrics API requirements #148
+496
−302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdudits
requested review from
Azquelt,
brunobat,
Emily-Jiang,
yasmin-aumeeruddy and
JanWesterkamp-iJUG
yasmin-aumeeruddy
requested changes
Dec 18, 2023
brunobat
requested changes
Jan 4, 2024
|
We will discuss this PR further in our next meeting on 15th Jan. @brunobat it will be great if you could attend that call. |
sure @Emily-Jiang |
tjquinno
suggested changes
Jan 15, 2024
brunobat
requested changes
Jan 23, 2024
brunobat
approved these changes
Feb 5, 2024
Emily-Jiang
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specification got refactored, so that common integration requirements are separate top-level section, just as section on configuration properties and APIs. It seemed more convenient to have that information at single location rather that have it spread across metrics and tracing (and common) sections.
Fixes #134.