fix: remove items from index implementations grid and tree (regression) #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karl Schrab <[email protected]>
schwepmo
reviewed
Oct 20, 2023
| }); | ||
| } | ||
| } | ||
|
|
||
| public void removeItem(T item) { | ||
| synchronized (tmpIndexA) { | ||
| CellIndex cellIndex = items.remove(item); | ||
| CellIndex cellIndex = items.remove(new ItemKey<>(adapter.getItemHash(item), item)); |
There was a problem hiding this comment.
Isn't this a little bit dirty? We have to instantiate a new ItemKey whenever we want to remove an item. 🤷 Also this is a duplicate of line 122. Maybe we can somewhat hide it by adding a method with the structure ItemKey<T> getKeyForItem(T Item)
There was a problem hiding this comment.
I didn't like either but I could not think of a better way. Performance/memory wise it should be okay to create this object just for removing the item. I followed your suggestions regarding hiding the instantiation.
Signed-off-by: Karl Schrab <[email protected]>
schwepmo
approved these changes
Oct 23, 2023
|
LGTM! Any reason you haven't checked any of the task boxes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VehicleObjectitems in theGridorQuadTree, they were stored as a key within a HashMap. When doing so, the hashCode of the object is used to store it in the map. However, when updating the object (e.g. adjusting its speed value), the object cannot be found anymore since its hashCode has changed and differs from the one stored in the map. This resulted in odd behavior andVehicleObjects could not be removed from theGridorQuadTreeand were therefore returned by the perception module,GridandQuadTreedo not store theVehicleObjectitems as a key for HashMaps, but only their hash value. This hash value is furthermore generated by theSpatialItemAdapter. The adapter implementation responsible for theVehicleObjectnow returns only the hashcode of its id which is immutable. This refactoring required in theGridimplementation a new wrapper classItemKeyto be used as a key for the internal HashMap, since direct access to the stored item was required.Issue(s) related to this PR
Affected parts of the online documentation
Changes in the documentation required?
Definition of Done
Prerequisites
Required
type(scope): description(in the style of Conventional Commits)enhancement, orbugfix)origin/mainhas been merged into your Fork.Requested (can be enforced by maintainers)
Special notes to reviewer