Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(general): Minor Cleanups #362

Merged
merged 3 commits into from
Nov 7, 2023
Merged

cleanup(general): Minor Cleanups #362

merged 3 commits into from
Nov 7, 2023

Conversation

schwepmo
Copy link
Contributor

@schwepmo schwepmo commented Nov 1, 2023

Description

  • This PR contains minor cleanups found while working on internal issue 715

Issue(s) related to this PR

  • Relates to internal issue 715

Affected parts of the online documentation

  • None

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

@schwepmo schwepmo added the clean-up Aesthetically improving code label Nov 1, 2023
@schwepmo schwepmo requested a review from kschrab November 1, 2023 15:07
@kschrab kschrab merged commit 13f0d12 into main Nov 7, 2023
1 check passed
@kschrab kschrab deleted the 715-fxd-fcd-cleanup branch November 7, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-up Aesthetically improving code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants