-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: various changes required for ride-hailing #370
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karl Schrab <[email protected]>
Signed-off-by: Karl Schrab <[email protected]>
Signed-off-by: Karl Schrab <[email protected]>
kschrab
added
enhancement
New feature or request
bugfix
Pull requests that fixes a bug
labels
Nov 30, 2023
schwepmo
reviewed
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left some remarks/questions on some method calls.
...ava/org/eclipse/mosaic/fed/application/ambassador/navigation/CentralNavigationComponent.java
Outdated
Show resolved
Hide resolved
...ava/org/eclipse/mosaic/fed/application/ambassador/navigation/CentralNavigationComponent.java
Show resolved
Hide resolved
Signed-off-by: Karl Schrab <[email protected]>
…f the queried connection Signed-off-by: Karl Schrab <[email protected]>
Signed-off-by: Karl Schrab <[email protected]>
schwepmo
reviewed
Dec 18, 2023
...ava/org/eclipse/mosaic/fed/application/ambassador/navigation/CentralNavigationComponent.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Karl Schrab <[email protected]>
schwepmo
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Various minor improvements/fixes required by recent applications related to ride-hailing.
mosaic-application
SimulationKernel
andCentralNavigationComponent
, but have been updated only inSimulationKernel
. This leads to buggy behavior when working with routes in applications. Now, routes are stored and updated only inSimulationKernel
.getConnection(id)
toINavigationModule
.mosaic-sumo
mapping_config.json
, it is not propagated tomosaic-sumo
, thus it is unknown and results in an NPE when processing aVehicleRegistration
interaction with a vehicle type not configured in mapping. Now you may ask: "how can a VehicleRegistration contain a vehicle type which was not used by spawner in mapping configuration?". Well, this can happen when aVehicleRegistration
is triggered from any other ambassador (e.g., from inside an application). To allow processing this, we now catch the NPE from happening and write alog.warn
that the user has to be sure, that the referred vehicle type must be at least known to SUMO (e.g., by adding them to anyrou.xml
).mosaic-routing
Issue(s) related to this PR
Affected parts of the online documentation
Changes in the documentation required?
No
Definition of Done
Prerequisites
Required
type(scope): description
(in the style of Conventional Commits)enhancement
, orbugfix
)origin/main
has been merged into your Fork.Requested (can be enforced by maintainers)
Special notes to reviewer