Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update and review third party dependencies #376

Merged
merged 19 commits into from
Mar 22, 2024
Merged

Conversation

kschrab
Copy link
Contributor

@kschrab kschrab commented Feb 23, 2024

Description

  • Updated several dependencies to recent versions
  • Replaced justify with json-schema-validator as justify. This way we could remove all jaxb depdencies.
  • Turned off logback messages of json-schema-validator, as they are very verbose (via logback(-test).xml)

Issue(s) related to this PR

  • Resolves issue internal issue #794

Affected parts of the online documentation

Changes in the documentation required?

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

@kschrab kschrab requested a review from rprotzmann February 23, 2024 16:38
@kschrab kschrab self-assigned this Feb 23, 2024
@kschrab kschrab added the dependencies Pull requests that update a dependency file label Feb 23, 2024
@kschrab
Copy link
Contributor Author

kschrab commented Mar 15, 2024

@rprotzmann I integrated your changes on license.merge file and pom.xml and updated NOTICE-THIRD-PARTY.md

Copy link
Contributor

@schwepmo schwepmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. I've left comments where I stumbled across some question.

@schwepmo schwepmo merged commit b68eac3 into main Mar 22, 2024
6 checks passed
@schwepmo schwepmo deleted the 794-third-party-update branch March 22, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants