Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(BerDiBa): Created RegionsConfigGammaDelayUtility.java #377

Conversation

iwillitried
Copy link
Contributor

@iwillitried iwillitried commented Feb 26, 2024

Description

Implemented a helper tool that configures a RandomGammaDelay for every up-/downlink in a regions.json (cell module) file

Issue(s) related to this PR

  • mosaic-extended#758

Affected parts of the online documentation

(none)

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • [ x origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

static class GeoPolygonAdapter extends TypeAdapter<GeoPoint> {
@Override
public void write(com.google.gson.stream.JsonWriter out, GeoPoint point) throws IOException {
out.beginObject();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any idea why the RegionsNamingStrategy does not work and you have to do this instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants