feat(sumo): LaneChangeMode.OFF should do no lane changes at all #383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LaneChangeMode.OFF
still did strategic lane changes, e.g. to follow a route.LaneChangeMode.OFF
disables all lane changes in SUMO, an additionalLaneChangeMode.FOLLOW_ROUTE
reprises the previous behavior, with all lane change reasons turned off, except strategic lane changes for route-following.Offtopic:
-b
) now works much better when pausing the simulation. Then it will not try to catch up to meet the configured real-time requirement. Instead, it will only do real-time sync for the last 1 second.What is this PR about?
Affected parts of the online documentation
Changes in the documentation required?
Not really, but https://eclipse.dev/mosaic/docs/develop_applications/operating_system/ is apparently broken (there is still milliseconds passed to
changeLane(..)
instead of nanoseconds.Definition of Done
Prerequisites
Required
type(scope): description
(in the style of Conventional Commits)enhancement
, orbugfix
)origin/main
has been merged into your Fork.Requested (can be enforced by maintainers)
Special notes to reviewer