Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sumo): LaneChangeMode.OFF should do no lane changes at all #383

Merged
merged 5 commits into from
Mar 22, 2024

Conversation

kschrab
Copy link
Contributor

@kschrab kschrab commented Mar 22, 2024

Description

  • Previously, LaneChangeMode.OFF still did strategic lane changes, e.g. to follow a route.
  • Now, LaneChangeMode.OFF disables all lane changes in SUMO, an additional LaneChangeMode.FOLLOW_ROUTE reprises the previous behavior, with all lane change reasons turned off, except strategic lane changes for route-following.
  • Furthermore, disallow negative numbers when calculating the target lane for a lane change.

Offtopic:

  • RTI real time synchronization (-b) now works much better when pausing the simulation. Then it will not try to catch up to meet the configured real-time requirement. Instead, it will only do real-time sync for the last 1 second.

What is this PR about?

Affected parts of the online documentation

Changes in the documentation required?

Not really, but https://eclipse.dev/mosaic/docs/develop_applications/operating_system/ is apparently broken (there is still milliseconds passed to changeLane(..) instead of nanoseconds.

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

@kschrab kschrab requested a review from schwepmo March 22, 2024 07:41
Copy link
Contributor

@schwepmo schwepmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kschrab kschrab merged commit e58293c into main Mar 22, 2024
6 checks passed
@kschrab kschrab deleted the 801-ainet-demo-scenario branch March 22, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants