-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: store etc-files in mosaic-starter and copy them to bundle #423
Conversation
…integration tests
Both IDE and bundled version tested, and they work fine 👍 I'm still a bit unsure, where the execution management will look for a file, that has no absolute path. For MosaicStarter it can be directly in it's own project folder works fine, and also in |
When starting MOSAIC with The runtime.json can also only be placed in both places, since the starter is implemented in a way that it looks in both locations: |
…ipse#423) * build: store etc-files in mosaic-starter and copy them to bundle and integration tests * clean: remove unnecessary properties from copy-resources definition
…ipse#423) * build: store etc-files in mosaic-starter and copy them to bundle and integration tests * clean: remove unnecessary properties from copy-resources definition
…ipse#423) * build: store etc-files in mosaic-starter and copy them to bundle and integration tests * clean: remove unnecessary properties from copy-resources definition
* build: store etc-files in mosaic-starter and copy them to bundle and integration tests * clean: remove unnecessary properties from copy-resources definition
Description
Default etc-files are now stored in
mosaic-starter/etc
rather than hidden inbundle/src/assembly/resources/etc
. To include them in the bundle, the maven config has been adjusted accordingly. This change has the main advantage, that changes in the etc-files do not require a call ofmvn validate
anymore to be effective when starting from the IDE.Issue(s) related to this PR
Affected parts of the online documentation
Changes in the documentation required?
Our internal developer-documentation must be changed, as well as website documentation.
Definition of Done
Prerequisites
Required
type(scope): description
(in the style of Conventional Commits)enhancement
, orbugfix
)origin/main
has been merged into your Fork.Requested (can be enforced by maintainers)
Special notes to reviewer