-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sns): support multi-hop unicast for topological and geographical routing #428
Conversation
edb45a2
to
6bbc442
Compare
@hoelger please review |
fed/mosaic-sns/src/main/java/org/eclipse/mosaic/fed/sns/ambassador/TransmissionSimulator.java
Outdated
Show resolved
Hide resolved
fed/mosaic-sns/src/main/java/org/eclipse/mosaic/fed/sns/ambassador/TransmissionSimulator.java
Outdated
Show resolved
Hide resolved
fed/mosaic-sns/src/main/java/org/eclipse/mosaic/fed/sns/model/AdhocTransmissionModel.java
Outdated
Show resolved
Hide resolved
fed/mosaic-sns/src/main/java/org/eclipse/mosaic/fed/sns/model/SimpleAdhocTransmissionModel.java
Outdated
Show resolved
Hide resolved
...-sns/src/main/java/org/eclipse/mosaic/fed/sns/model/SophisticatedAdhocTransmissionModel.java
Outdated
Show resolved
Hide resolved
Here are two/three other minor improvements, one is just style, the other two are performance optimizations, so that in case of no-delivery the loops don't count up to I couldn't comment that in the PR because it's not directly part of the changes |
6bbc442
to
6c73ef4
Compare
Good suggestions. I added them to my change. |
...-sns/src/main/java/org/eclipse/mosaic/fed/sns/model/SophisticatedAdhocTransmissionModel.java
Outdated
Show resolved
Hide resolved
...-sns/src/main/java/org/eclipse/mosaic/fed/sns/model/SophisticatedAdhocTransmissionModel.java
Show resolved
Hide resolved
Apart from one minor comment: LGTM |
… exit if flooding could not be progressed)
bdec8eb
to
bf888a4
Compare
… routing (eclipse#428) * feat(sns): cleanup, minor performance improvement for flooding (early exit if flooding could not be progressed)
… routing (eclipse#428) * feat(sns): cleanup, minor performance improvement for flooding (early exit if flooding could not be progressed)
… routing (#428) * feat(sns): cleanup, minor performance improvement for flooding (early exit if flooding could not be progressed)
Description
SNS covers already various addressing/routing modes. With this MR, multihop unicast for both topoligic or geographic routing are added by re-using existing methods. Multi-hop Broadcast is still missing.
✅Multihop (new)
❌Multihop
✅Multihop (new)
✅Multihop
The
SimpleAdHocTransmissionModel
does not really count hops between single vehicles, but instead uses a configured multi-hop delay which is applied as soon as more than hop is required.The
SophisticatedAdHocTransmissionModel
uses existing methodforward
(which was initially used by the Geographic routing) to send the message to a specific vehicle in the unicast mode via multiple hops.The geographic unicast was implemented by simply reducing the list of potential receivers in the target geo area to the one destination vehicle.
Issue(s) related to this PR
Affected parts of the online documentation
Changes in the documentation required?
Kind of, we should add supported features (such as the table above) to our website documentation.
Definition of Done
Prerequisites
Required
type(scope): description
(in the style of Conventional Commits)enhancement
, orbugfix
)origin/main
has been merged into your Fork.Requested (can be enforced by maintainers)
Special notes to reviewer