Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dev-option to ns3 installation script #435

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

hoelger
Copy link
Contributor

@hoelger hoelger commented Nov 13, 2024

Description

Have a flag that allows to keep source code when installing ns3

Issue(s) related to this PR

  • Resolves internal issue 926

Affected parts of the online documentation

Changes in the documentation required? No.

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

@kschrab kschrab changed the title 926 improve ns3 setup scripts for devs feat: add dev-option to ns3 installation script Nov 19, 2024
@hoelger hoelger force-pushed the 926-improve-ns3-setup-scripts-for-devs branch from b3764ae to c33a31b Compare November 19, 2024 09:41
@hoelger hoelger force-pushed the 926-improve-ns3-setup-scripts-for-devs branch from 4cc8232 to 4f4aeb1 Compare November 19, 2024 10:33
@kschrab kschrab merged commit bec61b5 into eclipse:main Nov 19, 2024
5 checks passed
schwepmo pushed a commit that referenced this pull request Dec 2, 2024
* refactor: tabs to spaces
* feat: provide dev mode where src files are not deleted
* feat: make available over CL args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants