Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactored CellMessageRoutingBuilder #437

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

FunKuchen
Copy link
Contributor

@FunKuchen FunKuchen commented Nov 19, 2024

Description

  • Refactored CellMessageRoutingBuilder to new standards
  • Every configurable aspect now has a seperate method in the builder
    • streaming(long streamDuration, long streamBandwidthInBitPs)
    • protocol(ProtocolType type)
      • tcp()
      • udp()
    • destination(NetworkAddress networkAddress)
      • destination(String receiverName)
      • destination(byte[] ipv4Address)
      • broadcast()
    • mbs()
    • topological()
    • geographical(GeoArea area)

What is this PR about?

Issue(s) related to this PR

  • Resolves part of internal issue 917

Affected parts of the online documentation

  • Changes in the communication documentation on the website are required
  • Addressed in internal issue 911

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

@kschrab kschrab added enhancement New feature or request clean-up Aesthetically improving code labels Nov 19, 2024
@kschrab kschrab merged commit 1c94711 into eclipse:main Nov 20, 2024
5 checks passed
schwepmo pushed a commit that referenced this pull request Dec 2, 2024
* fix: Added comments for CellMessageRoutingBuilder and fixed AdHocMessageRoutingBuilder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-up Aesthetically improving code enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants