Remove use of Object
in headers and store header value as rpm tag v…
#62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…alue
An attempt at removing some duplicate code between
RpmTagValue
andRpmInformations
.Improve type safety by always storing a
HeaderEntry
in the header map instead of rawObject
. This required a small API change to callgetValue()
now to get the actual value, and the stored value was changed toRpmTagValue
instead ofObject
inside theHeaderEntry
itself.I think another possible improvement that is not in this pull request as it requires more code changes is to avoid returning
Object
from theget()
API, and instead return anRpmTagValue
and have the caller have to provideasLong()
orasString()
instead of casting, which may provide better type safety.