[UPC#441] pass the request and check args

lib/Ravada.pm

@@ -1716,7 +1716,7 @@ sub _cmd_open_iptables {
 sub _cmd_clone($self, $request) {
     my $domain = Ravada::Domain->open($request->args('id_domain'));
 
-    my @args = ();
+    my @args = ( request => $request);
     push @args, ( memory => $request->args('memory'))
         if $request->defined_arg('memory');
 

lib/Ravada/Domain.pm

@@ -477,6 +477,8 @@ Returns: Domain object read only
 =cut
 
 sub open($class, $id) {
+    confess "Missing id"    if !defined $id;
+
     my $self = {};
 
     if (ref($class)) {
@@ -1007,6 +1009,7 @@ sub clone {
 
     my @args_copy = ();
     push @args_copy, ( memory => $args{memory} )  if $args{memory};
+    push @args_copy, ( request => $args{request} )  if $args{request};
 
     my $clone = $self->_vm->create_domain(
         name => $name
@@ -1023,13 +1026,18 @@ sub _copy_clone($self, %args) {
     my $name = delete $args{name} or confess "ERROR: Missing name";
     my $user = delete $args{user} or confess "ERROR: Missing user";
     my $memory = delete $args{memory};
+    my $request = delete $args{request};
 
     confess "ERROR: Unknown arguments ".join(",",sort keys %args)
         if keys %args;
 
     my $base = Ravada::Domain->open($self->id_base);
 
-    my @copy_arg = ( memory => $memory ) if $memory;
+    my @copy_arg;
+    push @copy_arg, ( memory => $memory ) if $memory;
+
+    $request->status("working","Copying domain ".$self->name
+        ." to $name");
     my $copy = $self->_vm->create_domain(
         name => $name
         ,id_base => $base->id
@@ -1690,9 +1698,10 @@ sub _pre_clone($self,%args) {
     my $name = delete $args{name};
     my $user = delete $args{user};
     my $memory = delete $args{memory};
+    delete $args{request};
 
     confess "ERROR: Missing clone name "    if !$name;
-    confess "ERROR: Invalid name '$name'"   if $name !~ /^[a-z][a-z0-9_-]+$/;
+    confess "ERROR: Invalid name '$name'"   if $name !~ /^[a-z0-9_-]+$/i;
 
     confess "ERROR: Missing user owner of new domain"   if !$user;