Copy DenseSet in IndexAxis.merge #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes seg fault #62.
We found a consistent clientside seg fault when using fdb-axes on the databridge. e.g.
fdb-axes class=d1,param=167,step=0,expver=0001,dataset=extremes-dt,levtype=sfc,stream=oper,type=fcwould seg fault.The problem:
When you call
axis.merge(some_read_only_axis), theaxisobject gains shared ownership of the read only object's denseset, allowing it to be modified. This corrupts the axis registry which makes assumptions that require its cached axis to be read only.This fix makes a copy of the axis when first merging, rather than sharing ownership.