Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Cobb Douglas rewards #1363

Merged
merged 6 commits into from
Jan 22, 2025
Merged

update Cobb Douglas rewards #1363

merged 6 commits into from
Jan 22, 2025

Conversation

alanlujan91
Copy link
Member

@alanlujan91 alanlujan91 commented Nov 22, 2023

for consumption and durables

Please ensure your pull request adheres to the following guidelines:

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

for consumption and durables
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (6aed7cc) 73.02% compared to head (d36b094) 72.96%.

Files Patch % Lines
HARK/rewards.py 40.90% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1363      +/-   ##
==========================================
- Coverage   73.02%   72.96%   -0.06%     
==========================================
  Files          79       79              
  Lines       13377    13403      +26     
==========================================
+ Hits         9769     9780      +11     
- Misses       3608     3623      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alanlujan91
Copy link
Member Author

Ready to review @AMonninger !

@akshayshanker
Copy link
Collaborator

akshayshanker commented Jan 4, 2025

@AMonninger. When you get a moment, can you please take a look at the additional rewards and marginal reward functions with durables and merge if OK?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.90909% with 26 lines in your changes missing coverage. Please review.

Project coverage is 72.96%. Comparing base (6aed7cc) to head (d36b094).
Report is 740 commits behind head on master.

Files with missing lines Patch % Lines
HARK/rewards.py 40.90% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1363      +/-   ##
==========================================
- Coverage   73.02%   72.96%   -0.06%     
==========================================
  Files          79       79              
  Lines       13377    13403      +26     
==========================================
+ Hits         9769     9780      +11     
- Misses       3608     3623      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mnwhite
Copy link
Contributor

mnwhite commented Jan 8, 2025

Matt to look at this.

@mnwhite
Copy link
Contributor

mnwhite commented Jan 22, 2025

Updated changelog, merging without running tests because tests passed before.

@mnwhite mnwhite merged commit 189b452 into econ-ark:master Jan 22, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants