Feature/refactor can modify vote to validator service #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magwas
reviewed
Jul 15, 2019
|
|
||
| @TestedFeature("Manage votes") | ||
| @TestedOperation("delete choice") | ||
| @RunWith(MockitoJUnitRunner.class) | ||
| public class ChoiceDeleteAdminKeyIsUserTest extends ChoiceTestBase { | ||
|
|
||
| private static final String NOT_SAME_USER_MESSAGE = | ||
| "The adminKey is \"user\" but the user is not same with that user who added the choice."; | ||
| private static final String CAN_ADDIN_IS_FALSE_MESSAGE = |
There was a problem hiding this comment.
Aren't those strings are constants in the production code?
There was a problem hiding this comment.
They are. If you mean, we should use constants of the production code, I suggest to forget it.
Let's imagine the situation, when someone accidentally removes some words from this string or an unlucky regex overwrites it. We wouldn't realize it, since we compare this constant to itself.
| voteAdminInfo, | ||
| choiceToDelete.getId() | ||
| ) | ||
| ).assertMessageIs("The adminKey is \"user\" but canAddin is false."); |
There was a problem hiding this comment.
Once a java constant, once an inline constant.
| assertThrows(() -> choiceService.deleteChoice(new VoteAdminInfo(vote.getId(), USER), | ||
| choiceToDelete.getId())).assertMessageIs("The adminKey is \"user\" but canAddin is false."); | ||
| final VoteAdminInfo voteAdminInfo = new VoteAdminInfo(vote.getId(), USER); | ||
| doThrow(new ReportedException(CAN_ADDIN_IS_FALSE_MESSAGE)) |
There was a problem hiding this comment.
Service stub, should be put into a stub provider.
| public class ChoiceModificationValidatorServiceTest | ||
| extends ChoiceValidatorBaseTest { | ||
|
|
||
| private static final String MODIFICATION = "modification"; |
| @@ -1,7 +1,8 @@ | |||
| package org.rulez.demokracia.pdengine.choice; | |||
|
|
|||
| import static org.junit.Assert.assertEquals; | |||
| import static org.mockito.Mockito.*; | |||
| import static org.mockito.Mockito.doThrow; | |||
There was a problem hiding this comment.
This is a sign that there are stubs which do not belong here.
| @@ -17,6 +18,11 @@ | |||
| @RunWith(MockitoJUnitRunner.class) | |||
| public class ChoiceModifyValidationTest extends ChoiceTestBase { | |||
|
|
|||
| private static final String DIFFERENT_USER_MESSAGE = | |||
| @@ -34,37 +40,50 @@ public void setUp() { | |||
| @TestedBehaviour(VALIDATES_INPUTS) | |||
| @Test | |||
| public void invalid_voteId_is_rejected() { | |||
| doThrow(new ReportedException("illegal voteId", invalidvoteId)).when(voteService) | |||
| doThrow(new ReportedException("illegal voteId", invalidvoteId)) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.