Remove ContainingBeats since it has been used only in tests. #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magwas
reviewed
Jul 15, 2019
| } | ||
|
|
||
| @Test | ||
| public void beatInformation_gives_back_the_number_of_winnings_from_choice1_to_choice2() { |
There was a problem hiding this comment.
Where are these functionalities tested?
| public void | ||
| beatInformation_throws_exception_when_getting_with_invalid_row_key() { | ||
| assertThrows( | ||
| () -> createNewBeatTableWithData().getElement(CHOICE1, "InvalidRow") |
There was a problem hiding this comment.
Test data in a unit test. Test data obtained through a method.
| public void | ||
| beatInformation_throws_exception_when_getting_with_invalid_column_key() { | ||
| assertThrows( | ||
| () -> createNewBeatTableWithData().getElement("InvalidColumn", CHOICE1) |
| @@ -25,7 +25,7 @@ | |||
|
|
|||
| @Before | |||
| public void setUp() { | |||
| BeatTable beatTable = createNewBeatTableWithComplexData(); | |||
| final BeatTable beatTable = createNewBeatTableWithComplexData(); | |||
There was a problem hiding this comment.
Test data obtained through a method
| @@ -37,7 +39,8 @@ public void transitive_closure_on_empty_beat_table_results_empty_result() { | |||
|
|
|||
| @Test | |||
| public void transitive_closure_computes_the_shortest_paths_by_pairs() { | |||
| beatTable = beatTableTransitiveClosureService.computeTransitiveClosure(beatTable); | |||
| beatTable = | |||
| beatTableTransitiveClosureService.computeTransitiveClosure(beatTable); | |||
There was a problem hiding this comment.
Test data created in situ below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.