fix: wrong UDP checksum in proxied GTPv1U packets #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please if possible better merge the PR without squashing the commits, so that git log diffs become clearer! :) |
|
Hi @pespin
Our PR management style is "one PR - one change". And that's why we prefer to squash commits. Additionally, we use conventional commits style (see https://www.conventionalcommits.org). So at least PR title should be refactored to satisfy commit style (title will be used as commit message after squash). Nevertheless, many thanks for your PR! --BR, Alex |
For now mark checksum as 0 to avoid transmitting with a wrong checksum, which would drop the packets at the receiver.
pespin
force-pushed
the
pespin/pr-udp-checksum
branch
from
d5cf5ba to
49a3d62
Compare
pespin
changed the title
pirog-spb
approved these changes
Nov 16, 2024
pirog-spb
changed the title
pirog-spb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now mark checksum as 0 to avoid transmitting with a wrong checksum,
which would drop the packets at the receiver.