Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the reject_recently_left_players plugin into the base game #628

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Added the reject_recently_left_players plugin into the base game #628

merged 2 commits into from
Oct 27, 2023

Conversation

EraOSBeta
Copy link
Collaborator

@EraOSBeta EraOSBeta commented Oct 24, 2023

Steps

  • Write a good description of what your PR does (and WHY it does it).
  • Add Rikko to CONTRIBUTORS.
  • Add a CHANGELOG entry if your change is non-trivial.
  • Ensure make preflight completes successfully.

Description

Imagine killing someone, them having to wait 7 seconds to respawn, and they just disconnect and reconnect and they're able to hop in the game immediately without having to wait even a second.

Originally a plugin by @rikkolovescats, this PR disallows any pb-id from joining the session for 10 seconds once the player leaves the session, this system works like the system in the c-layer that disallows people from joining for 10 seconds after they leave, but this system supports disconnections and reconnections, allowing a fair game.

It's also worth noting that this system does not stop people from joining if authenticate_clients is set to false in the config and the player sends a join request to the server before the server fetches the pb-id, this is intentional as the server has requested the client to not be authenticated.

Type of Changes

Type
✨ New feature

@EraOSBeta
Copy link
Collaborator Author

Also Eric you add the CHANGELOG entry I'm too lazy.

@EraOSBeta EraOSBeta marked this pull request as ready for review October 24, 2023 12:07
@efroemling
Copy link
Owner

Thanks for the improvement! My only comment would be to add some comments on what the code is doing, but I'll go ahead and do that.

@efroemling efroemling merged commit 5cd779f into efroemling:master Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants