Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github action for nightly build and to make release #701

Merged
merged 14 commits into from
Jun 12, 2024

Conversation

Loup-Garou911XD
Copy link
Contributor

@Loup-Garou911XD Loup-Garou911XD commented May 20, 2024

Steps

  • Write a good description of what your PR does (and WHY it does it).
  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a CHANGELOG entry if your change is non-trivial.
  • Ensure make preflight completes successfully.

Description

  • Added github action to build docker image and sphinx docs nightly instead of on every commit to save time on checks
  • Added github action to release build files on tag push
  • Added some comments to makefile docker targets

Type of Changes

Type
✨ New feature

@Loup-Garou911XD
Copy link
Contributor Author

Loup-Garou911XD commented May 20, 2024

should we build every thing nightly or just docs and docker image?
also should deploy docs also be run nightly instead of every commit?

@Loup-Garou911XD Loup-Garou911XD marked this pull request as draft May 20, 2024 14:42
@Loup-Garou911XD Loup-Garou911XD marked this pull request as ready for review May 20, 2024 17:22
@Loup-Garou911XD
Copy link
Contributor Author

@efroemling should the releases be release build or debug build??

@Loup-Garou911XD
Copy link
Contributor Author

here if you want to see how release looks

@Loup-Garou911XD
Copy link
Contributor Author

Loup-Garou911XD commented May 20, 2024

you can edit the body of release manually to highlight major changes or i can write a script that gets everything from CHANGELOG.md like i did here on plugman repo
In my opinion the latter is not suitable here as the full changelog can be overwhelming

@Loup-Garou911XD Loup-Garou911XD changed the title Added github action to build docker image and sphinx docs nightly Added github action for nightly build and to make release May 22, 2024
@Loup-Garou911XD Loup-Garou911XD changed the title Added github action for nightly build and to make release Github action for nightly build and to make release May 22, 2024
@efroemling
Copy link
Owner

Thanks for this!

@efroemling efroemling merged commit df0cf5f into efroemling:master Jun 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants