Log account changes as join, not mode console level.

[DasBrain]

(Only channel ops can change modes, users can change their own account)

Found by: DasBrain
Patch by: DasBrain
Fixes:

One-line summary:
Account changes are logged using +j (join, parts, quits, aways and netsplits) not +k (kick, bans and mode changes) console level.

Additional description (if needed):

Test cases demonstrating functionality (if applicable):

[thommey]

what's the rationale for changing it? we deliberately thought JOIN is suitable

[DasBrain]

Currently account changes are logged as mode changes, not join.

A channel member doing a /msg NickServ identify should is not a mode change, which may for example be audited.
(A log with mode changes/kicks can be used as audit log for operator actions - an ordinary channel member logging some stuff in there doesn't fit it in my opinion.)

So I agree:

we deliberately thought JOIN is suitable

[vanosg]

I think @thommey misspoke on this one- I think we deliberately made it a MODE flag, not JOIN flag, because join is associated with a single channel and an account change is more global in nature. I do recall a very large discussion we had on this topic at the time but can't remember details any more... While I was initially in favor of JOIN, I think my mind was changed, but I'm not sure why it is MODE now. Maybe SERV?

[DasBrain]

Hard to argue with that reasoning. So, yeah...

I view ACCOUNT messages similar to NICK changes.
Both apply to the user in all common channels.

NICK is also logged in +j, if I remember correctly.

And I think I already explained why I prefer account changes on +j: To not clutter up some "operator audit log" - anything else in +k requires channel operator status to trigger.