(WIP) strncpy() + manual NULL terminating -> strlcpy() #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: michaelortmann
Patch by: michaelortmann
Fixes:
One-line summary:
strncpy()+ manualNULLterminating ->strlcpy()Additional description (if needed):
Old code uses
strncpy()combined with manualNULLterminating.This is exactly what
strlcpy()is good for.So lets replace the few remaining
strncpys()and test each of those code pathes.Test cases demonstrating functionality (if applicable):
1st commit was tested by linking 2 bots. In this case
addbot()is called and the new code is executed.HANDLEN + 1==sizeof ptr2->bot==33.