Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add channel with bogus option #1746

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

michaelortmann
Copy link
Member

Found by: fred0r
Patch by: michaelortmann
Fixes: #974

One-line summary:
Do not add channel with bogus option

Additional description (if needed):

Test cases demonstrating functionality (if applicable):
Before:

.+chan #bogusfoo +bogusbar
[04:46:39] tcl: builtin dcc call: *dcc:+chan -HQ 1 #bogusfoo +bogusbar
[04:46:39] [!s] JOIN #bogusfoo
Invalid channel or channel options.
[04:46:39] [s->] JOIN #bogusfoo
[...]

After:

.+chan #bogusfoo +bogusbar
[04:47:40] tcl: builtin dcc call: *dcc:+chan -HQ 1 #bogusfoo +bogusbar
Invalid channel or channel options.
.channel #bogusfoo
[04:47:43] tcl: builtin dcc call: *dcc:channel -HQ 1 #bogusfoo
No such channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'.+chan #channel +incativ' shouldnt create #channel
1 participant