Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RFC and WIP) Send SETNAME to server, when cap setname enabled and realname is changed #1757

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

michaelortmann
Copy link
Member

@michaelortmann michaelortmann commented Feb 1, 2025

Found by: michaelortmann
Patch by: michaelortmann
Fixes:

One-line summary:
(WIP) Send SETNAME to server, when cap setname enabled and realname is changed

Additional description (if needed):
Also raise max botrealname from 80 to 130. all irc servers have default 50. and then there is inspircd:

maxreal 	Number 	130 	The maximum length of a real name.
https://docs.inspircd.org/4/configuration/

Test cases demonstrating functionality (if applicable):

    Active CAP negotiations: setname
    isupport: WHOX WATCHOPTS=A WATCH=128 WALLCHOPS USERIP UHNAMES TOPICLEN=360 TARGMAX=DCCALLOW:,ISON:,JOIN:,KICK:4,KILL:,LIST:,NAMES:1,NOTICE:1,PART:,PRIVMSG:4,SAJOIN:,SAPART:,TAGMSG:1,USERHOST:,USERIP:,WATCH:,WHOIS:1,WHOWAS:1 STATUSMSG=~&@%+ SILENCE=15 SAFELIST QUITLEN=307 PREFIX=(qaohv)~&@%+ NICKLEN=30 NETWORK=ExampleNET NAMESX NAMELEN=50 MSGREFTYPES=msgid,timestamp MONITOR=128 MODES=12 MINNICKLEN=0 MAXNICKLEN=30 MAXLIST=b:60,e:60,I:60 MAP
[...]
.set realname foo42
[02:40:08] tcl: builtin dcc call: *dcc:set -HQ 1 realname foo42
[02:40:08] #-HQ# set realname foo42
DEBUG: traced_realname() namelen005 = 50
[02:40:08] [!s] SETNAME foo42
Ok, set.
[02:40:08] [s->] SETNAME foo42
[02:40:08] [@] :test23!tcl9eggdro@Clk-8553FB0D SETNAME :foo42

@michaelortmann
Copy link
Member Author

michaelortmann commented Feb 3, 2025

Link #1514 and #1756

@michaelortmann michaelortmann changed the title (WIP) Send SETNAME to server, when cap setname enabled and realname is changed (RFC and WIP) Send SETNAME to server, when cap setname enabled and realname is changed Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant