chore: Add note about hashers in readme #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not evidently clear that the hashers need to be explicitly "added" so this readme note is an attempt to correct that.
oblique
approved these changes
Jan 7, 2025
oblique
changed the title
|
Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, thanks for making a bitswap in Rust! This is great.
Once I started using it, I did lose my mind as to why some bit were not swapping.
After digging, finding the
hashersmodule, I realized hashers need to be explicitly added.Since it's not evidently clear on the front page that the hashers need to be explicitly "added", this readme note is an attempt to correct that.
Hopefully this will save someone else some time!