-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to coq/coq#19927 (coq-core renamed to rocq-runtime) #883
Conversation
Doesn't quite work, I get - - 2 Coq path directory bindings in scope; 27 Coq plugin directory bindings in scope
+ - 2 Coq path directory bindings in scope; 0 Coq plugin directory bindings in scope |
I'll have a look tomorrow and try to fix it. |
@SkySkimmer you missed the occurence in Anyways this code can be removed as we don't use the findlib method anymore, I actually have a coq-lsp branch that does that but it will take a while for me to return back to work unfortunately. |
@SkySkimmer you mind bumping the (And adapt to other changes like the worker build, etc...) Also serlib needs (an easy) fix for its Note that I plan to make the loader not so hacky, also got a branch for that somewhere. |
IDK how to do that |
|
But the vendored git repo only knows about coq/coq, my branch is in skyskimmer/coq |
Good questions, I'm not sure I make it work, as I use Never mind if that's too hard. |
I edited .gitmodules to point at my fork |
Updated rest of the system, including the missing change to Let's see how it goes. |
As I've mentioned, this will change to "X findlib paths in scope" for Rocq 9.0 |
Co-authored-by: Emilio Jesús Gallego Arias <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI green, local and JS tests OK too.
There are many more occurrences of
coq-core
in this repo but I don't know what they're doing. This patch is just enough to fix Coq's CI.