Add support for Reply-To. #58
Conversation
Allow setting the Reply-To header through the "reply_to" attribute or by setting extra headers. Support both email address and "name <email>".
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
=========================================
+ Coverage 60.22% 63.63% +3.4%
=========================================
Files 1 1
Lines 88 99 +11
Branches 22 27 +5
=========================================
+ Hits 53 63 +10
Misses 29 29
- Partials 6 7 +1
Continue to review full report at Codecov.
|
sgbackend/mail.py
Outdated
| @@ -104,8 +104,28 @@ def _build_sg_mail(self, email): | |||
| for k, v in email.substitutions.items(): | |||
| personalization.add_substitution(Substitution(k, v)) | |||
|
|
|||
| # SendGrid does not support adding Reply-To as an extra | |||
| # header, so it needs to be manually removed if it exists. | |||
| reply_to_string = "" | |||
| for k, v in email.extra_headers.items(): | |||
There was a problem hiding this comment.
please rename to key, value
There was a problem hiding this comment.
the entire file uses the k, v naming, so it makes sense to keep the consistency.
|
@andriisoldatenko, I've updated the pull request as you asked. Could you please give it another review when you get time? |
|
Hey guys, when will you merge it with the upstream branch? I really needed this fix :) |
|
@elbuo8 do you have any comments? |
|
Guys, will you update the package version and sources in the PyPi? |
|
yep, will do soon. |
|
Sorry, underwater these days :/
On Mon, Sep 25, 2017 at 7:18 AM Andrii Soldatenko ***@***.***> wrote:
yep, will do soon.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#58 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABHUqlCEAuIb4hgtoiQsXQxWTBNi7VoMks5sl4v6gaJpZM4Oaq6j>
.
--
Yamil Asusta
@elbuo8 <https://twitter.com/elbuo8>
|
|
@elbuo8 no problem, thank you for the library :) Will you be able to upload new version into PyPi in this week? |
|
There is no power/internet in PR (I live here). Will try to upload when I
get to the US.
On Thu, Sep 28, 2017 at 12:11 PM Sergey Khalymon ***@***.***> wrote:
@elbuo8 <https://github.com/elbuo8> no problem, thank you for the
library. Will you be able to upload new version into PyPi in this week?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#58 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABHUqlpW9JA9BBrce7YJjmjxc4fV0Cghks5sm8VMgaJpZM4Oaq6j>
.
--
Yamil Asusta
@elbuo8 <https://twitter.com/elbuo8>
|
Allow setting the Reply-To header through the "reply_to" attribute or by setting extra headers. Support both email address and "name ".