replication connection respects reconnect_backoff option #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Jan 18, 2025
| @@ -487,6 +487,7 @@ defmodule Postgrex.ReplicationConnection do | |||
| def handle_event(type, content, state, s) | |||
|
|
|||
| def handle_event({:timeout, :backoff}, nil, @state, s) do | |||
| Process.sleep(s.reconnect_backoff) | |||
There was a problem hiding this comment.
The state machine (gen_statem) has an API for sleeping, so that's where it happens. Roughly around line 500:
{:keep_state, s, {{:timeout, :backoff}, s.reconnect_backoff, nil}}
There was a problem hiding this comment.
Sorry, I'm not familiar with gen_statem so I'm reading the code now.
Are you referring to this?
https://github.com/erlang/otp/blob/OTP-27.2/lib/stdlib/src/gen_statem.erl#L1188
But anyway when I test after tweaking reconnect_backoff to a huge number,
ReplicationConnection still immediately tries to reconnect without any delay.
|
Thanks @DohanKim, if it is indeed not triggering, we should address it by using the @whatyouhide can you give us a hand with this one? You have better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replication Connection's {:timeout, :backoff} action does not wait for the time as reconnect_backoff option set.