Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some implementations still rely on ssrc attributes in SDP offer/answer when demuxing incoming RTP packets (e.g. Pion). While including a=ssrc attribute in the SDP is obsoleted and we should demux by mid, this is still correct and supported by web browsers.
This PR adds ssrc attributes to the SDP offer/answer when a transceiver is
sendonly
orsendrecv
.A couple of notes:
a=ssrc:1234
attribute, it should also always hascname
attr i.e.a=ssrc:1234 cname:qW34eced
app_data
in msid according to what JSEP says. This app_data does not make any sense anyway as its value is MediaStreamTrack.id, which can change without renegotiation (e.g. when calling rtpsender.replaceTrack)