Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(types): include $pwa module augmentation types for Nuxt and Vue #2462

Closed
wants to merge 2 commits into from

Conversation

userquin
Copy link
Member

@userquin userquin commented Nov 8, 2023

VSCode (also working when using IntelliJ and should work also with WebStorm):

imagen

imagen

Copy link

stackblitz bot commented Nov 8, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 755a584
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/654bfb3c556f730007c49708

Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 755a584
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/654bfb3cc39112000816c861
😎 Deploy Preview https://deploy-preview-2462--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@userquin userquin requested a review from danielroe November 8, 2023 20:43
@userquin
Copy link
Member Author

userquin commented Nov 8, 2023

upps, reviewing what's happening with $scrollToTop and $i18n...

@userquin userquin changed the title chore(types): fix $pwa module augmentation types for Nuxt and Vue chore(types): include $pwa module augmentation types for Nuxt and Vue Nov 8, 2023
@userquin
Copy link
Member Author

userquin commented Dec 2, 2023

superseded by #2498

@userquin userquin closed this Dec 2, 2023
@userquin userquin deleted the userquin/fix-pwa-types branch December 2, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant