Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2296 Use React Testing Library for common-properties tests - Part 2-… #2297

Closed
wants to merge 4 commits into from
Closed

#2296 Use React Testing Library for common-properties tests - Part 2-… #2297

wants to merge 4 commits into from

Conversation

Jerinjk14
Copy link
Contributor

fixes: #2296
Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@Jerinjk14
elyra-ai#2296 Use React Testing Library for common-properties tests -…
f7e8a7c 
… Part 2-final-implementing

Signed-off-by: Jerin George <[email protected]>
@Jerinjk14 Jerinjk14 requested a review from nmgokhale January 10, 2025 16:55
nmgokhale
nmgokhale reviewed Jan 10, 2025
View reviewed changes
...s_modules/common-canvas/__tests__/common-properties/operators/dm-condition-operators-test.js Outdated
expect(dropdownList).to.be.length(14);
dropdownList.at(2).simulate("click");
wrapper.update();
fireEvent.click(dropdownList[2]);
expect(controller.getControlState({ name: "checkbox3" })).to.equal("visible");
});

// This works in the UI but errorMessages is not updated in test
it.skip("selectColumn control becomes validated if selected item has a dmRole equal to discrete", () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try fixing this test

nmgokhale
nmgokhale reviewed Jan 10, 2025
View reviewed changes
...s_modules/common-canvas/__tests__/common-properties/operators/dm-condition-operators-test.js Outdated
errorMessages = controller.getErrorMessages();
expect(controller.getErrorMessages()).to.deep.equal({});
expect(errorMessages).to.deep.equal({});
});

// This works in the UI but errorMessages is not updated in test
it.skip("selectColumn control become validated if selected item does not have a dmRole equal to discrete", () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try fixing this test

@Jerinjk14 Jerinjk14 requested a review from caritaou January 29, 2025 13:38
caritaou
caritaou reviewed Jan 29, 2025
View reviewed changes
...s_modules/common-canvas/__tests__/common-properties/operators/dm-condition-operators-test.js
expect(errorMessages.dmMeasurementEqualList.type).to.equal("error");
});
// Manually updating the store
sinon.stub(controller, "getErrorMessages")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this is stubbed? This doesn't really test what we want since we are forcing the messages to return the values we expect

...s_modules/common-canvas/__tests__/common-properties/operators/dm-condition-operators-test.js
dropdownButton.simulate("click");
dropdownList.at(1).simulate("click"); // Fulfill Condition by selecting item with dmRole input
const getErrorMessage = sinon.stub(controller, "getErrorMessages");
getErrorMessage.onFirstCall().returns({});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above. If we are forcing the messages to return {} then its not really testing that the error messages are cleared. Instead, are you able to verify on the UI side that the error icon appears and disappears after selection?

@Jerinjk14 Jerinjk14 closed this Feb 4, 2025
@Jerinjk14
Copy link
Contributor Author

New PR for this issue : #2331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caritaou caritaou caritaou left review comments

@nmgokhale nmgokhale nmgokhale left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use React Testing Library for common-properties tests - Part 2-final
3 participants
@Jerinjk14 @caritaou @nmgokhale