lsp-inline-completion, lsp-copilot: fix lints, package version and default behavior on inserting text #4662
Conversation
kiennq
changed the title
kiennq
force-pushed
the
fix/lsp-package-version-nil
branch
from
7a0e0c5 to
f3b0ecb
Compare
| (start-point (or start (point))) | ||
| (showing-at-eol (save-excursion | ||
| (goto-char start-point) | ||
| (eolp))) | ||
| (and (not (bolp)) (eolp)))) |
There was a problem hiding this comment.
If I recall correctly, I had to handle this specifically because the overlay did not display at the right place when EOL. In this case, I had display the overlay at the character before eol (I believe this was a hint I took from the company preview frontend).
I don't remember seeing the same issue on bol (and have not been able to get copilot to answer anything at bol, so I can't test it), so I'm curious -- why shift the overlay display point when bol?
There was a problem hiding this comment.
You can try with this elisp code where the <|> is cursor position.
;; fibonacci
<|>Basically, in this case, the cursor will be moved back to the previous line since it's eol. However, we don't want that and will want to keep the cursor in the current line.
Here is before the fix
|
Consider rebasing this to check for any further errors in snapshots. |
kiennq
force-pushed
the
fix/lsp-package-version-nil
branch
from
f3b0ecb to
b25000c
Compare
Fix #4660 and #4656