Fix SWI2 IRQ handler with nrf_pac
#280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirbaio
reviewed
Nov 16, 2024
nrf-softdevice/src/events.rs
Outdated
| )] | ||
| unsafe extern "C" fn swi2_irq_handler() { | ||
| SWI2_SOC_EVT_WAKER.wake(); | ||
| SWI2_BLE_EVT_WAKER.wake(); | ||
| } | ||
|
|
||
| /// Support older PACs which use a different name for the SWI2 interrupt | ||
| #[cfg_attr( |
There was a problem hiding this comment.
this should be cfg and not cfg_attr so the function is not emitted at all in '05, '10, '11.
There was a problem hiding this comment.
Yep. I also removed the allow(dead_code) attribute from the main handler since that warning should only affect nrf_softdevice directly and not downstream projects (and we're using nrf_pac in nrf_softdevice so the warning doesn't happen).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.