Search Component #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please don't just merge this PR. The point of this is for you to review the changes. There are 3 commits, focus on Simplified: CRA Scaffolding, Search Components. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Emily,
We never got around to doing a screen share, but I thought I'd give you some feedback/help on this any way. I've refactored the initial Search components a bit to be much simpler, we could refactor them to use React Hooks if you'd like to see how that works, but I tried to take what you had and keep the overarching logic so it'd be easy to see what I did.
I can look at other parts of the project as I find time, or if you have a preference/priority list, feel free to let me know and we'll make things happen.