Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:throw an error for invaild json string #1515

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

ni00
Copy link
Contributor

@ni00 ni00 commented Dec 7, 2023

PR Checklist

What is the current behavior?

Please describe the current behavior and link to a relevant issue.

The functions JSONBigInt.parse() and JSONBigNumber.parse() generate an error when encountering an invalid JSON string, but do not properly throw it.

img1

Issue Number

What is the new behavior?

img2

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Other information

@ysfscream ysfscream self-assigned this Dec 7, 2023
@ysfscream ysfscream added CLI MQTTX CLI web MQTTX Web desktop MQTTX Desktop labels Dec 7, 2023
@ysfscream ysfscream added this to the v1.9.7 milestone Dec 7, 2023
@ysfscream ysfscream assigned ni00 and unassigned ysfscream Dec 7, 2023
@ysfscream ysfscream merged commit 75dd168 into emqx:main Dec 7, 2023
6 checks passed
@ysfscream
Copy link
Member

Thanks! 🚀 @ni00

@ysfscream ysfscream added the fix Fix bug or issues label Dec 7, 2023
@ni00 ni00 deleted the json-error-fix branch May 16, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI MQTTX CLI desktop MQTTX Desktop fix Fix bug or issues web MQTTX Web
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants