feat: start-link gun process #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
commented
Dec 14, 2023
| end | ||
| ) | ||
| end}, | ||
| {timeout, 20, fun() -> |
There was a problem hiding this comment.
this test is removed because OTP 26 no longer checks timeout arg validity.
it crashes in inet module.
zmstone
force-pushed
the
1214-start-link-gun-process
branch
from
6b93d5e to
aa499dc
Compare
|
need this for dialyzer: emqx/gun#7 |
zmstone
force-pushed
the
1214-start-link-gun-process
branch
from
5230a53 to
ad87094
Compare
ieQu1
approved these changes
Dec 15, 2023
keynslug
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gun:opentogun:start_linkto start the gun process.This makes the gun process linked to
ehttpcprocess (instead ofgun_sup).Prior to this change, some early errors causing gun process to crash might not be able to be caught by ehttpc due to the slow monitoring.
e.g. when some SSL option is invalid, the gun process will crash immediately and
ehttpccan only get anoprocerror reason from the delayed process monitor.